-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: handle MRD jobs correctly in computeDeploymentPaused #14649
Conversation
…DeploymentPaused, make sure to check whether the deployment hasn't existed in the past. This affects MRD and other type of evaluations that do not have deployments.
ee8afd5
to
802d342
Compare
Add conditions for checking more deployment scenarios, such as job updates, job re-registration after purge, and evals not triggered by job registration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Tim Gross <tgross@hashicorp.com>
2606266
to
b41ff40
Compare
Marking it as draft for now as we found more cases that need to be handled. |
Closing this in favour of #15325 |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
when making a check for non-existing deployment in
computeDeploymentPaused
, make sure to check whether the deployment hasn't existed in the past. This affects MRD and other type of evaluations that do not have deployments.Resolves https://github.com/hashicorp/nomad-enterprise/issues/737