scheduler: handle MRD jobs correctly in computeDeploymentPaused #14649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkazmierczak
added
theme/enterprise
…DeploymentPaused, make sure to check whether the deployment hasn't existed in the past. This affects MRD and other type of evaluations that do not have deployments.
pkazmierczak
force-pushed
the
b-mrd-allocs-not-starting
branch
from
ee8afd5
to
802d342
Compare
Add conditions for checking more deployment scenarios, such as job updates, job re-registration after purge, and evals not triggered by job registration.
pkazmierczak
changed the title
tgross
reviewed
Sep 26, 2022
tgross
reviewed
Sep 26, 2022
Co-authored-by: Tim Gross <tgross@hashicorp.com>
lgfa29
force-pushed
the
b-mrd-allocs-not-starting
branch
from
2606266
to
b41ff40
Compare
|
Marking it as draft for now as we found more cases that need to be handled. |
|
Closing this in favour of #15325 |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when making a check for non-existing deployment in
computeDeploymentPaused, make sure to check whether the deployment hasn't existed in the past. This affects MRD and other type of evaluations that do not have deployments.Resolves https://github.com/hashicorp/nomad-enterprise/issues/737