Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fingerprint: lengthen Vault check after seen #14693

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Commits on Sep 26, 2022

  1. fingerprint: lengthen Vault check after seen

    Extension of #14673
    
    Once Vault is initially fingerprinted, extend the period since changes
    should be infrequent and the fingerprint is relatively expensive since
    it is contacting a central Vault server.
    
    Also move the period timer reset *after* the fingerprint. This is
    similar to #9435 where the idea is to ensure the retry period starts
    *after* the operation is attempted. 15s will be the *minimum* time
    between fingerprints now instead of the *maximum* time between
    fingerprints.
    
    In the case of Vault fingerprinting, the original behavior might cause
    the following:
    
    1. Timer is reset to 15s
    2. Fingerprint takes 16s
    3. Timer has already elapsed so we immediately Fingerprint again
    
    Even if fingerprinting Vault only takes a few seconds, that may very
    well be due to excessive load and backing off our fingerprints is
    desirable. The new bevahior ensures we always wait at least 15s between
    fingerprint attempts and should allow some natural jittering based on
    server load and network latency.
    schmichael committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    d85a084 View commit details
    Browse the repository at this point in the history