Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: recover from getter panics #14696

Merged
merged 2 commits into from
Sep 26, 2022
Merged

client: recover from getter panics #14696

merged 2 commits into from
Sep 26, 2022

Commits on Sep 26, 2022

  1. client: recover from getter panics 

    The artifact getter uses the go-getter library to fetch files from
different sources. Any bug in this library that results in a panic can
cause the entire Nomad client to crash due to a single file download
attempt.

This change aims to guard against this types of crashes by recovering
from panics when the getter attempts to download an artifact. The
resulting panic is converted to an error that is stored as a task event
for operator visibility and the panic stack trace is logged to the
client's log.
    @lgfa29
    lgfa29 committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    301cecd View commit details
    Browse the repository at this point in the history

  2. changelog: add entry for #14696

    @lgfa29
    lgfa29 committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    9a8ae96 View commit details
    Browse the repository at this point in the history