Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: defer nobody user lookup so Windows doesn't panic #14790

Merged
merged 3 commits into from
Oct 4, 2022
Merged

client: defer nobody user lookup so Windows doesn't panic #14790

merged 3 commits into from
Oct 4, 2022

Commits on Oct 4, 2022

  1. client: defer nobody user lookup so Windows doesn't panic 

    In #14742 we introduced a cached lookup of the `nobody` user, which is only ever
called on Unixish machines. But the initial caching was being done in an `init`
block, which meant it was being run on Windows as well. This prevents the Nomad
agent from starting on Windows.

An alternative fix here would be to have a separate `init` block for Windows and
Unix, but this potentially masks incorrect behavior if we accidentally added a
call to the `Nobody()` method on Windows later. This way we're forced to handle
the error in the caller.
    @tgross
    tgross committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    46c2a1f View commit details
    Browse the repository at this point in the history

  2. remove init entirely

    @tgross
    tgross committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    393ac63 View commit details
    Browse the repository at this point in the history

  3. oops, double-locked by self

    @tgross
    tgross committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    f25df89 View commit details
    Browse the repository at this point in the history