Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Makes service tags wrap and look like tag items #14834

Merged
merged 4 commits into from
Oct 7, 2022

Conversation

philrenaud
Copy link
Contributor

Resolves #14832

Fixes an issue where, if there were many tags on a service, they would bleed off-page.

Now, we show them as ui-conventional tags and wrap them.

Gratuitous example:
image

@philrenaud philrenaud self-assigned this Oct 6, 2022
@philrenaud philrenaud linked an issue Oct 6, 2022 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Ember Asset Size action

As of 08650fe

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +90 B +25 B
nomad-ui.css +116 B +38 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Ember Test Audit comparison

main 04a40a0 change
passes 1423 1423 0
failures 0 0 0
flaky 0 0 0
duration 10m 33s 777ms 11m 30s 545ms +56s 768ms

@philrenaud philrenaud added the backport/1.4.x backport to 1.4.x release line label Oct 7, 2022
@philrenaud philrenaud merged commit 5d56e9e into main Oct 7, 2022
@philrenaud philrenaud deleted the 14832-ui-service-tags-splitting branch October 7, 2022 13:23
@philrenaud philrenaud added this to the 1.4.2 milestone Oct 18, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.4.x backport to 1.4.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: services with many tags do not display properly
2 participants