Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exec: allow running commands from host volume #14851

Merged
merged 3 commits into from
Nov 11, 2022
Merged

exec: allow running commands from host volume #14851

merged 3 commits into from
Nov 11, 2022

Commits on Nov 10, 2022

  1. exec: allow running commands from host volume

    The exec driver and other drivers derived from the shared executor check the
    path of the command before handing off to libcontainer to ensure that the
    command doesn't escape the sandbox. But we don't check any host volume mounts,
    which should be safe to use as a source for executables if we're letting the
    user mount them to the container in the first place.
    
    Check the mount config to verify the executable lives in the mount's host path,
    but then return an absolute path within the mount's task path so that we can hand
    that off to libcontainer to run.
    
    Includes a good bit of refactoring here because the anchoring of the final task
    path has different code paths for inside the task dir vs inside a mount. But
    I've fleshed out the test coverage of this a good bit to ensure we haven't
    created any regressions in the process.
    tgross committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    e4fc11e View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. Configuration menu
    Copy the full SHA
    0fd8108 View commit details
    Browse the repository at this point in the history
  2. add search order to docs

    tgross committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    e565ffe View commit details
    Browse the repository at this point in the history