Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services: remove assertion on 'task' field being set #14864

Merged
merged 1 commit into from
Oct 10, 2022

Commits on Oct 10, 2022

  1. services: remove assertion on 'task' field being set

    This PR removes the assertion around when the 'task' field of
    a check may be set. Starting in Nomad 1.4 we automatically set
    the task field on all checks in support of the NSD checks feature.
    
    This is causing validation problems elsewhere, e.g. when a group
    service using the Consul provider sets 'task' it will fail
    validation that worked previously.
    
    The assertion of leaving 'task' unset was only about making sure
    job submitters weren't expecting some behavior, but in practice
    is causing bugs now that we need the task field for more than it
    was originally added for.
    
    We can simply update the docs, noting when the task field set by
    job submitters actually has value.
    shoenig committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    589b6d5 View commit details
    Browse the repository at this point in the history