Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of make version checks specific to region (1.4.x) into release/1.4.x #14916

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #14912 to be assessed for backporting due to the inclusion of the label backport/1.4.x.

The below text is copied from the body of the original PR.


  • One-time tokens are not replicated between regions, so we don't want to enforce
    that the version check across all of serf, just members in the same region.
  • Scheduler: Disconnected clients handling is specific to a single region, so we
    don't want to enforce that the version check across all of serf, just members in
    the same region.
  • Variables: enforce version check in Apply RPC
  • Cleans up a bunch of legacy checks.

This changeset is specific to 1.4.x and the changes for previous versions of
Nomad will be manually backported in separate PRs.

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/b-region-filter-server-version-check-1.4/widely-cuddly-phoenix branch from 91450b7 to c698b9d Compare October 17, 2022 20:24
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit e7c06b0 into release/1.4.x Oct 17, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/b-region-filter-server-version-check-1.4/widely-cuddly-phoenix branch October 17, 2022 20:24
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants