Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul: register checks along with service on initial registration #14944

Merged
merged 4 commits into from
Oct 19, 2022

Commits on Oct 18, 2022

  1. consul: register checks along with service on initial registration

    This PR updates Nomad's Consul service client to include checks in
    an initial service registration, so that the checks associated with
    the service are registered "atomically" with the service. Before, we
    would only register the checks after the service registration, which
    causes problems where the service is deemed healthy, even if one or
    more checks are unhealthy - especially problematic in the case where
    SuccessBeforePassing is configured.
    
    Fixes #3935
    shoenig committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    1660905 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. Configuration menu
    Copy the full SHA
    0f730ed View commit details
    Browse the repository at this point in the history
  2. cr: fix another bug

    shoenig committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    33c7ad1 View commit details
    Browse the repository at this point in the history
  3. cr: fixup changelog

    shoenig committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    0307c7c View commit details
    Browse the repository at this point in the history