Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of consul: register checks along with service on initial registration into release/1.2.x #14958

Merged

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #14944 to be assessed for backporting due to the inclusion of the label backport/1.2.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

The below text is copied from the body of the original PR.


This PR updates Nomad's Consul service client to include checks in
an initial service registration, so that the checks associated with
the service are registered "atomically" with the service. Before, we
would only register the checks after the service registration, which
causes problems where the service is deemed healthy, even if one or
more checks are unhealthy - especially problematic in the case where
SuccessBeforePassing is configured.

Fixes #3935

Note this doesn't address service de-registrations; which we'll get to in #10482

@hashicorp-cla
Copy link

hashicorp-cla commented Oct 19, 2022

CLA assistant check
All committers have signed the CLA.

@shoenig shoenig force-pushed the backport/f-atomic-consul/gratefully-modern-insect branch from 5dccd5a to 3d9c9f6 Compare October 19, 2022 17:53
@tgross tgross added this to the 1.4.2 milestone Oct 19, 2022
@shoenig shoenig merged commit f5a5d91 into release/1.2.x Oct 19, 2022
@shoenig shoenig deleted the backport/f-atomic-consul/gratefully-modern-insect branch October 19, 2022 18:53
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants