Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keyring: fix missing GC config, don't rotate on manual GC #15009

Merged
merged 2 commits into from
Oct 24, 2022
Merged

keyring: fix missing GC config, don't rotate on manual GC #15009

merged 2 commits into from
Oct 24, 2022

Commits on Oct 21, 2022

  1. keyring: fix missing GC config, don't rotate on manual GC 

    The configuration knobs for root keyring garbage collection are present in the
consumer and present in the user-facing config, but we missed the spot where we
copy from one to the other. Fix this so that users can set their own thresholds.

The root key is automatically rotated every ~30d, but the function that does
both rotation and key GC was wired up such that `nomad system gc` caused an
unexpected key rotation. Split this into two functions so that `nomad system gc`
cleans up old keys without forcing a rotation, which will be done periodially
or by the `nomad operator root keyring rotate` command.
    @tgross
    tgross committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    c099139 View commit details
    Browse the repository at this point in the history

  2. changelog entries

    @tgross
    tgross committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    86b01de View commit details
    Browse the repository at this point in the history