-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keyring: safely handle missing keys and restore GC #15092
Merged
Merged
Commits on Oct 31, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e880bce - Browse repository at this point
Copy the full SHA e880bceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c3a830 - Browse repository at this point
Copy the full SHA 6c3a830View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae083a2 - Browse repository at this point
Copy the full SHA ae083a2View commit details -
keyring: fix early return on replication errors
When replication of a single key fails, the replication loop broke early and therefore keys that fell later in the sorting order would never get replicated. Log the error and continue. Refactor the replication loop so that each key replicated in a function call that returns an error, to make the workflow more clear and reduce nesting.
Configuration menu - View commit details
-
Copy full SHA for 7fb2d1d - Browse repository at this point
Copy the full SHA 7fb2d1dView commit details -
improve stability of keyring replication tests
We no longer block leadership on initializing the keyring, so there's a race condition in the keyring tests where we can test for the existence of the root key before the keyring has been initialize. Change this to an "eventually" test.
Configuration menu - View commit details
-
Copy full SHA for 15fd16a - Browse repository at this point
Copy the full SHA 15fd16aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 782d03e - Browse repository at this point
Copy the full SHA 782d03eView commit details
Commits on Nov 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 571118f - Browse repository at this point
Copy the full SHA 571118fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b571f0 - Browse repository at this point
Copy the full SHA 2b571f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6962168 - Browse repository at this point
Copy the full SHA 6962168View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd3c556 - Browse repository at this point
Copy the full SHA bd3c556View commit details -
Co-authored-by: Charlie Voiselle <464492+angrycub@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 3d98ea1 - Browse repository at this point
Copy the full SHA 3d98ea1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.