Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WI: set identity to client secret if missing #15121

Merged
merged 1 commit into from
Nov 3, 2022
Merged

WI: set identity to client secret if missing #15121

merged 1 commit into from
Nov 3, 2022

Commits on Nov 3, 2022

  1. WI: set identity to client secret if missing 

    Allocations created before 1.4.0 will not have a workload identity token. When
the client running these allocs is upgraded to 1.4.x, the identity hook will run
and replace the node secret ID token used previously with an empty string. This
causes service discovery queries to fail.

Fallback to the node's secret ID when the allocation doesn't have a signed
identity. Note that pre-1.4.0 allocations won't have templates that read
Variables, so there's no threat that this new node ID secret will be able to
read data that the allocation shouldn't have access to.
    @tgross
    tgross committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    18a8217 View commit details
    Browse the repository at this point in the history