Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix s3 example URLs in the artifacts docs #15123

Merged
merged 2 commits into from Nov 7, 2022
Merged

Fix s3 example URLs in the artifacts docs #15123

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b19180
Fix s3 URLs so that they work
Nov 3, 2022
282d8ba
Use s3:// protocol schema for artifact examples
Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions website/content/docs/job-specification/artifact.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ This example uses path-based notation on a publicly-accessible bucket:

```hcl
artifact {
source = "https://my-bucket-example.s3-us-west-2.amazonaws.com/my_app.tar.gz"
source = "my-bucket-example.s3-us-west-2.amazonaws.com/my_app.tar.gz"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
source = "my-bucket-example.s3-us-west-2.amazonaws.com/my_app.tar.gz"
source = "s3://my-bucket-example.s3-us-west-2.amazonaws.com/my_app.tar.gz"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated this in a follow-up commit

}
```

Expand Down Expand Up @@ -240,7 +240,7 @@ Alternatively you can use virtual hosted style:

```hcl
artifact {
source = "https://my-bucket-example.s3-eu-west-1.amazonaws.com/my_app.tar.gz"
source = "my-bucket-example.s3-eu-west-1.amazonaws.com/my_app.tar.gz"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
source = "my-bucket-example.s3-eu-west-1.amazonaws.com/my_app.tar.gz"
source = "s3://my-bucket-example.s3-eu-west-1.amazonaws.com/my_app.tar.gz"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated this in a follow-up commit

}
```

Expand Down