Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template: error on missing key #15141

Merged
merged 3 commits into from
Nov 4, 2022
Merged

template: error on missing key #15141

merged 3 commits into from
Nov 4, 2022

Conversation

angrycub
Copy link
Contributor

@angrycub angrycub commented Nov 4, 2022

This PR adds the consul-template configuration option error_on_missing_key. This allows jobspec authors to specify that a template should fail if it references a map key that does not exist. The default value is false and should be fully backward compatible.

This PR does not prevent the template engine from performing normal blocking behavior for functions that use blocking queries. This solely addresses the missing key in a map case. The other cases can be managed by using a non-blocking alternative and the sprig_fail «message» function

This PR replaces #14002, just because it was easier to hand recreate it then to tease through the merge conflicts.

Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The other cases can be managed by using a non-blocking alternative and the sprig_fail «message» function

An example of this would be a nice addition to the docs 🙂

@github-actions
Copy link

github-actions bot commented Mar 5, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants