Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of cli: report server version into release/1.4.x #15172

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #9159 to be assessed for backporting due to the inclusion of the label backport/1.4.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

The below text is copied from the body of the original PR.


Issue #1040

This is my first PR here 😄

Summary

Originally, I was going to set a X-Nomad-Version on every request, then check the header on every request to any API, but I didn't think it was very clean and it would be a big changeset. I also thought it might get annoying for users to see the warning for several commands.

Instead, I just added the revision to nomad server members -detailed.

Name          Address    Port  Tags
linux.global  127.0.0.1  4648  port=4647,raft_vsn=3,role=nomad,revision=3bf31ce64e762641787d8cc2c6a46a36a90816b6+CHANGES,bootstrap=1,expect=1,dc=dc1,build=1.2.6-dev,region=global,rpc_addr=127.0.0.1,id=94139a45-1000-023c-c809-8e9434ace143

@hashicorp-cla
Copy link

hashicorp-cla commented Nov 7, 2022

CLA assistant check
All committers have signed the CLA.

@tgross tgross force-pushed the backport/issue-1040/warn-on-mismatched-nomad-versions/gently-workable-muskox branch from 8ddc4e1 to b97b84a Compare November 7, 2022 15:38
@tgross tgross merged commit 21fbe3e into release/1.4.x Nov 7, 2022
@tgross tgross deleted the backport/issue-1040/warn-on-mismatched-nomad-versions/gently-workable-muskox branch November 7, 2022 15:53
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants