Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of client: avoid unconsumed channel in timer construction into release/1.2.x #15217

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Backport of client: avoid unconsumed channel in timer construction into release/1.2.x #15217

merged 1 commit into from
Nov 11, 2022

Commits on Nov 11, 2022

  1. client: avoid unconsumed channel in timer construction (#15215) 

    * client: avoid unconsumed channel in timer construction

This PR fixes a bug introduced in #11983 where a Timer initialized with 0
duration causes an immediate tick, even if Reset is called before reading the
channel. The fix is to avoid doing that, instead creating a Timer with a non-zero
initial wait time, and then immediately calling Stop.

* pr: remove redundant stop
    @shoenig
    shoenig committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    864f732 View commit details
    Browse the repository at this point in the history