Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyring: update handle to state inside replication loop #15227

Merged
merged 3 commits into from
Nov 17, 2022

Commits on Nov 15, 2022

  1. keyring: update handle to state inside replication loop

    When keyring replication starts, we take a handle to the state store. But
    whenever a snapshot is restored, this handle is invalidated and no longer points
    to a state store that is receiving new keys. This leaks a bunch of memory too!
    
    In addition to operator-initiated restores, when fresh servers are added to
    existing clusters with large-enough state, the keyring replication can get
    started quickly enough that it's running before the snapshot from the existing
    clusters have been restored.
    
    Fix this by updating the handle to the state store whenever the store's abandon
    channel is closed. Refactor the query for key metadata to use blocking queries
    for efficiency.
    tgross committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    e7703d1 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. move binding for AbandonCh

    tgross committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    b3f8ff5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    82fce0a View commit details
    Browse the repository at this point in the history