-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: ensure ACL role upsert decode error returns a 400 status code. #15253
api: ensure ACL role upsert decode error returns a 400 status code. #15253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nice catch. This may be, in theory, an API breaking change? Either way, having a changelog entry would be good.
Ah yeah I should have mentioned that the related PR has a changelog entry that will cover this. |
Oh right, you did mention that this part of another PR. Don't mind me 😅 |
a24e67b
to
9b55ffc
Compare
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Related to #15252 and forms the changes that will be back-ported into 1.4.x. This was built from the mentioned PR, and therefore that should be merged first.
It also includes a semgrep rule to catch this behaviour moving forward.