api: ensure ACL role upsert decode error returns a 400 status code. #15253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgfa29
approved these changes
Nov 17, 2022
Ah yeah I should have mentioned that the related PR has a changelog entry that will cover this. |
|
Oh right, you did mention that this part of another PR. Don't mind me 😅 |
Base automatically changed from
jrasell/b-http-endpoint-ensure-decode-400-error-resp
to
main
November 18, 2022 16:04
This was referenced Nov 18, 2022
jrasell
force-pushed
the
jrasell/b-http-endpoint-ensure-decode-400-error-resp-1.4
branch
from
a24e67b
to
9b55ffc
Compare
jrasell
deleted the
jrasell/b-http-endpoint-ensure-decode-400-error-resp-1.4
branch
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #15252 and forms the changes that will be back-ported into 1.4.x. This was built from the mentioned PR, and therefore that should be merged first.
It also includes a semgrep rule to catch this behaviour moving forward.