Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of test: ensure leader is still valid in reelection test into release/1.4.x #15268

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #15267 to be assessed for backporting due to the inclusion of the label backport/1.4.x.

The below text is copied from the body of the original PR.


The TestLeader_Reelection test waits for a leader to be elected and then makes some other assertions. But it implcitly assumes that there's no failure of leadership before shutting down the leader, which can lead to a panic in the tests. Assert there's still a leader before the shutdown.

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/test-fix-leader-election/hugely-suited-flounder branch from 2289f67 to 331a8eb Compare November 16, 2022 16:04
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit b640a11 into release/1.4.x Nov 16, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/test-fix-leader-election/hugely-suited-flounder branch November 16, 2022 16:04
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants