consul: add trace logging around service registrations #15311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoenig
force-pushed
the
b-consul-diff-log
branch
from
4a66266
to
ec811d6
Compare
This PR adds trace logging around the differential done between a Nomad service registration and its corresponding Consul service registration, in an effort to shed light on why a service registration request is being made.
shoenig
force-pushed
the
b-consul-diff-log
branch
from
ec811d6
to
e7ffbfb
Compare
jrasell
approved these changes
Nov 21, 2022
tgross
added
backport/1.4.x
tgross
approved these changes
Nov 21, 2022
|
I've added the 1.4.x backport label but I'm looking at #14917 and I think we probably need to backport to 1.3.x and 1.2.x as well? |
shoenig
added a commit
that referenced
this pull request
Nov 21, 2022
This PR adds trace logging around the differential done between a Nomad service registration and its corresponding Consul service registration, in an effort to shed light on why a service registration request is being made.
shoenig
added a commit
that referenced
this pull request
Nov 21, 2022
This PR adds trace logging around the differential done between a Nomad service registration and its corresponding Consul service registration, in an effort to shed light on why a service registration request is being made. Co-authored-by: Seth Hoenig <shoenig@duck.com>
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds trace logging around the differential done between a Nomad service registration and its corresponding Consul service registration, in an effort to shed light on why a service registration request is being made.
Should help with #15265