Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler: create placements for non-register MRD #15325

Merged
merged 2 commits into from
Nov 25, 2022
Merged

scheduler: create placements for non-register MRD #15325

merged 2 commits into from
Nov 25, 2022

Commits on Nov 19, 2022

  1. scheduler: create placements for non-register MRD 

    For multiregion jobs, the scheduler does not create placements on
registration because the deployment must wait for the other regions.
Once of these regions will then trigger the deployment to run.

Currently, this is done in the scheduler by considering any eval for a
multiregion job as "paused" since it's expected that another region will
eventually unpause it.

This becomes a problem where evals not triggered by a job registration
happen, such as on a node update. These types of regional changes do not
have other regions waiting to progress the deployment, and so they were
never resulting in placements.

The fix is to create a deployment at job registration time. This
additional piece of state allows the scheduler to differentiate between
a multiregion change, where there are other regions engaged in the
deployment so no placements are required, from a regional change, where
the scheduler does need to create placements.

This deployment starts in the new "initializing" status to signal to the
scheduler that it needs to compute the initial deployment state. The
multiregion deployment will wait until this deployment state is
persisted and its starts is set to "pending". Without this state
transition it's possible to hit a race condition where the plan applier
and the deployment watcher may step of each other and overwrite their
changes.
    @lgfa29
    lgfa29 committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    569ab1a View commit details
    Browse the repository at this point in the history

  2. changelog: add entry for #15325

    @lgfa29
    lgfa29 committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    7d21ad8 View commit details
    Browse the repository at this point in the history