Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of consul: fixup expected consul tagged_addresses when using ipv6 into release/1.3.x #15444

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #15411 to be assessed for backporting due to the inclusion of the label backport/1.3.x.

The below text is copied from the body of the original PR.


This PR is a continuation of #14917, where we missed the ipv6 cases.

Consul auto-inserts tagged_addresses for keys

  • lan_ipv4
  • wan_ipv4
  • lan_ipv6
  • wan_ipv6

even though the service registration coming from Nomad does not contain such
elements. When doing the differential between services Nomad expects to be
registered vs. the services actually registered into Consul, we must first
purge these automatically inserted tagged_addresses if they do not exist in
the Nomad view of the Consul service.

Fixes #15265

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/b-purge-ipv6-tagged-addresses/cheaply-normal-gobbler branch from 59d68c5 to adb53a9 Compare December 1, 2022 13:39
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit 11a290c into release/1.3.x Dec 1, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/b-purge-ipv6-tagged-addresses/cheaply-normal-gobbler branch December 1, 2022 13:39
@github-actions
Copy link

github-actions bot commented Apr 1, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants