Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acl: added type to ACL Auth Method stub #15480

Merged
merged 3 commits into from
Dec 6, 2022
Merged

acl: added type to ACL Auth Method stub #15480

merged 3 commits into from
Dec 6, 2022

Conversation

pkazmierczak
Copy link
Contributor

@pkazmierczak pkazmierczak commented Dec 6, 2022 •
edited
Loading

Relates to #13120

@vercel
Copy link

vercel bot commented Dec 6, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nomad-storybook-and-ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 6, 2022 at 10:39AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
nomad ⬜️ Ignored (Inspect) Dec 6, 2022 at 10:39AM (UTC)

@pkazmierczak pkazmierczak marked this pull request as ready for review December 6, 2022 10:32
@pkazmierczak pkazmierczak self-assigned this Dec 6, 2022
@pkazmierczak pkazmierczak changed the title bugfix: added type to ACL Auth Method stub acl: added type to ACL Auth Method stub Dec 6, 2022
jrasell
jrasell approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pkazmierczak pkazmierczak merged commit 7ee82dc into main Dec 6, 2022
@pkazmierczak pkazmierczak deleted the b-add-type-to-stub-list-auth-method branch December 6, 2022 13:47
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrasell jrasell jrasell approved these changes

Assignees

@pkazmierczak pkazmierczak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkazmierczak @jrasell