Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add raft snapshot configuration options #15522

Merged
merged 11 commits into from
Jan 20, 2023
Merged

Add raft snapshot configuration options #15522

merged 11 commits into from
Jan 20, 2023

Conversation

angrycub
Copy link
Contributor

@angrycub angrycub commented Dec 9, 2022

This plumbs raft snapshot configuration out to the server config

@angrycub angrycub self-assigned this Dec 9, 2022
This was referenced Dec 14, 2022
Merged
Open
schmichael
schmichael approved these changes Jan 5, 2023
View reviewed changes
command/agent/config.go Outdated Show resolved Hide resolved
@mikenomitch mikenomitch added the hcc/cst Admin - internal label Jan 20, 2023
@angrycub angrycub marked this pull request as ready for review January 20, 2023 16:35
@tgross tgross changed the title [wip] Add raft snapshot configuration options Add raft snapshot configuration options Jan 20, 2023
tgross
tgross approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one thing around validation we should probably fix, but other than that this LGTM! Nice work

.changelog/15522.txt Outdated Show resolved Hide resolved
command/agent/agent.go Outdated Show resolved Hide resolved
@angrycub angrycub merged commit 85f67d4 into main Jan 20, 2023
@angrycub angrycub deleted the f-raft-knobs branch January 20, 2023 19:21
@tgross tgross added this to the 1.5.0 milestone Jan 20, 2023
lgfa29 added a commit that referenced this pull request Jan 31, 2023
@lgfa29
changelog: fix entris for #15522 and #15819
668954b
lgfa29 added a commit that referenced this pull request Feb 1, 2023
@lgfa29
changelog: fix entries for #15522 and #15819 (#15998)
41065ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmichael schmichael schmichael approved these changes

@tgross tgross tgross approved these changes

Assignees

@angrycub angrycub

Labels
hcc/cst Admin - internal theme/raft type/enhancement
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@angrycub @schmichael @tgross @mikenomitch