Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stale querystring parameter value as boolean #15605

Merged
merged 9 commits into from
Jan 1, 2023
Merged

fix: stale querystring parameter value as boolean #15605

merged 9 commits into from
Jan 1, 2023

Commits on Dec 21, 2022

  1. Add changes to make stale querystring param boolean 

    Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
    @dttung2905
    dttung2905 committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    af36e52 View commit details
    Browse the repository at this point in the history

  2. Make error message more consistent 

    Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
    @dttung2905
    dttung2905 committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    62018ee View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2022

  1. Changes from code review + Adding CHANGELOG file 

    Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
    @dttung2905
    dttung2905 committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    4ed12c9 View commit details
    Browse the repository at this point in the history

  2. Changes from code review to use github.com/shoenig/test package 

    Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
    @dttung2905
    dttung2905 committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    b4141e7 View commit details
    Browse the repository at this point in the history

  3. Change must.Nil() to must.NoError() 

    Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
    @dttung2905
    dttung2905 committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    4daf080 View commit details
    Browse the repository at this point in the history

  4. Minor fix on the import order 

    Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
    @dttung2905
    dttung2905 committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    9776b92 View commit details
    Browse the repository at this point in the history

  5. Fix existing code format too 

    Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
    @dttung2905
    dttung2905 committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    f00ed41 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2022

  1. Minor changes addressing code review feedbacks 

    Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
    @dttung2905
    dttung2905 committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    5a50a71 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2022

  1. swap must.EqOp() order of param provided 

    Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
    @dttung2905
    dttung2905 committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    70c9b36 View commit details
    Browse the repository at this point in the history