Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of csi: Fix parsing of '=' in secrets at command line and HTTP into release/1.3.x #15674

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #15670 to be assessed for backporting due to the inclusion of the label backport/1.3.x.

The below text is copied from the body of the original PR.


Fixes #15663

The command line flag parsing and the HTTP header parsing for CSI secrets incorrectly split at more than one '=' rune, making it impossible to use secrets that included that rune.

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/b-csi-volume-secrets-parsing/luckily-informed-hyena branch from 2fd02a2 to 14fa442 Compare January 3, 2023 21:29
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit 3c9ce86 into release/1.3.x Jan 3, 2023
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/b-csi-volume-secrets-parsing/luckily-informed-hyena branch January 3, 2023 21:29
@github-actions
Copy link

github-actions bot commented May 5, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants