Backport of CI: run tests on pull_request and push to main/release into release/1.4.x #15693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Running tests `on: push` prevents GitHub from showing the workflow approval button, which prevents tests from being run on community-contributed (or even just non-Nomad HashiCorp folks) PRs. Running `on: pull_request` automatically picks up opened, reopened, and synchronize hooks (where "synchronize" means a push to HEAD on the PR's branch, so that'll pick up rebases and updates). But we also want to run tests on `main` and the various `release` backport branches, so retain a `on: push` for those.
tgross
force-pushed
the
backport/ci-on-pr/largely-settled-hyena
branch
from
a3d3b3f
to
07b2f76
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #15690 to be assessed for backporting due to the inclusion of the label backport/1.4.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Running tests
on: pushprevents GitHub from showing the workflow approval button, which prevents tests from being run on community-contributed (or even just non-Nomad HashiCorp folks) PRs. Runningon: pull_requestautomatically picks up opened, reopened, and synchronize hooks (where "synchronize" means a push to HEAD on the PR's branch, so that'll pick up rebases and updates).But we also want to run tests on
mainand the variousreleasebackportbranches, so retain a
on: pushfor those.Closes #15632