Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of fingerprint: add fingerprinting for CNI plugin versions into release/1.3.x #15729

Merged

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #15452 to be assessed for backporting due to the inclusion of the label backport/1.3.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

The below text is copied from the body of the original PR.


This PR adds a fingerprinter to set the attribute
"plugins.cni.version.<name>" -> version of the CNI plugin if present at $client.cni_path

First half of #14022
Second half will be adding an implicit constraint on applicable jobs.

e.g.

➜ nomad node status -self -verbose | grep plugins.cni.version
plugins.cni.version.bandwidth   = v1.0.0
plugins.cni.version.bridge      = v1.0.0
plugins.cni.version.custom      = v1.0.3
plugins.cni.version.dhcp        = v1.0.0
plugins.cni.version.firewall    = v1.0.0
plugins.cni.version.host-device = v1.0.0
plugins.cni.version.host-local  = v1.0.0
plugins.cni.version.ipvlan      = v1.0.0
plugins.cni.version.loopback    = v1.0.0
plugins.cni.version.macvlan     = v1.0.0
plugins.cni.version.portmap     = v1.0.0
plugins.cni.version.ptp         = v1.0.0
plugins.cni.version.sbr         = v1.0.0
plugins.cni.version.static      = v1.0.0
plugins.cni.version.tuning      = v1.0.0
plugins.cni.version.vlan        = v1.0.0
plugins.cni.version.vrf         = v1.0.0

Targets 1.5.0

@hashicorp-cla
Copy link

hashicorp-cla commented Jan 9, 2023

CLA assistant check
All committers have signed the CLA.

This PR adds a fingerprinter to set the attribute
"plugins.cni.version.<name>" => "<version>"

for each CNI plugin in <client>.cni_path (/opt/cni/bin by default).
@shoenig shoenig force-pushed the backport/f-cni-plugins/mostly-precious-blowfish branch from ddda4c9 to 65c28a5 Compare January 9, 2023 16:10
@shoenig shoenig merged commit 3574818 into release/1.3.x Jan 9, 2023
@shoenig shoenig deleted the backport/f-cni-plugins/mostly-precious-blowfish branch January 9, 2023 16:42
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants