Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of consul: add client configuration for grpc_ca_file into release/1.2.x #15752

Merged

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #15701 to be assessed for backporting due to the inclusion of the label backport/1.2.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

The below text is copied from the body of the original PR.


This combined with hashicorp/consul#15913 should be enough to get folks unblocked in upgrading to Consul 1.14 with TLS enabled and using Connect.

Unfortunately the breaking change on the Consul side combined with the new config required on the Nomad side implies the upgrade path for affected folks requires reconfiguration and restarting the Consul and Nomad agents together. Further, users who now specify a CA for grpc connections distinct from the Consul HTTP CA will need to drain each node of existing Connect services making use of the Envoy proxy - otherwise existing services will begin to fail to receive xDS config changes from Consul.

Note that Nomad users will also need to either configure consul.grpc_address to the 8503 default tls grpc port, or modify Consul config to listen to grpc tls on port 8502, e.g.

in nomad.hcl

consul {
  grpc_ca_file = "/etc/tls/consul-agent-ca.pem"
  ca_file = "/etc/tls/consul-agent-ca.pem"
  cert_file = "/etc/tls/dc1-client-consul-0.pem"
  key_file = "/etc/tls/dc1-client-consul-0-key.pem"
  ssl = true
  address = "127.0.0.1:8501"
  grpc_address = "127.0.0.1:8503"
}

Closes #15360

@hashicorp-cla
Copy link

hashicorp-cla commented Jan 11, 2023

CLA assistant check
All committers have signed the CLA.

@shoenig shoenig force-pushed the backport/b-consul-grpc-ca/openly-strong-bluegill branch from a03d05f to f768c80 Compare January 11, 2023 15:42
@shoenig shoenig force-pushed the backport/b-consul-grpc-ca/openly-strong-bluegill branch from f768c80 to 4026a7b Compare January 11, 2023 15:45
* [no ci] first pass at plumbing grpc_ca_file

* consul: add support for grpc_ca_file for tls grpc connections in consul 1.14+

This PR adds client config to Nomad for specifying consul.grpc_ca_file

These changes combined with hashicorp/consul#15913 should
finally enable Nomad users to upgrade to Consul 1.14+ and use tls grpc connections.

* consul: add cl entgry for grpc_ca_file

* docs: mention grpc_tls changes due to Consul 1.14
@shoenig shoenig force-pushed the backport/b-consul-grpc-ca/openly-strong-bluegill branch from 4026a7b to fe9e9f4 Compare January 11, 2023 15:46
@shoenig shoenig merged commit f12d160 into release/1.2.x Jan 11, 2023
@shoenig shoenig deleted the backport/b-consul-grpc-ca/openly-strong-bluegill branch January 11, 2023 16:39
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants