Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consul: correctly interpret missing consul checks as unhealthy #15822

Merged
merged 4 commits into from
Jan 19, 2023
Merged

consul: correctly interpret missing consul checks as unhealthy #15822

merged 4 commits into from
Jan 19, 2023

Commits on Jan 19, 2023

  1. consul: correctly understand missing consul checks as unhealthy 

    This PR fixes a bug where Nomad assumed any registered Checks would exist
in the service registration coming back from Consul. In some cases, the
Consul may be slow in processing the check registration, and the response
object would not contain checks. Nomad would then scan the empty response
looking for Checks with failing health status, finding none, and then
marking a task/alloc as healthy.

In reality, we must always use Nomad's view of what checks should exist as
the source of truth, and compare that with the response Consul gives us,
making sure they match, before scanning the Consul response for failing
check statuses.

Fixes #15536
    @shoenig
    shoenig committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    dcc19d4 View commit details
    Browse the repository at this point in the history

  2. consul: minor CR refactor using maps not sets

    @shoenig
    shoenig committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    d103467 View commit details
    Browse the repository at this point in the history

  3. consul: observe transition from healthy to unhealthy checks

    @shoenig
    shoenig committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    e16c489 View commit details
    Browse the repository at this point in the history

  4. consul: spell healthy correctly

    @shoenig
    shoenig committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    2be222b View commit details
    Browse the repository at this point in the history