acl: make auth method default across all types #15869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasell
approved these changes
Jan 26, 2023
Comment on lines
+143
to
+145
| if l.authMethodType == "" { | ||
| l.authMethodType = authMethod.Type | ||
| } |
There was a problem hiding this comment.
What happens if the user specifies the auth method type, but this does not match the default one found? I assume the login will fail further down the flow, and wonder if we either want to error on this, or overwrite the passed flag value?
There was a problem hiding this comment.
Right, it crossed my mind. I think it's fine to let it fail down the line, I don't think we should be overwriting things. Are you ok with this? or do you want to make a check here and fail quickly?
There was a problem hiding this comment.
ok maybe it's best to fail quickly.
3e7dab8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with the team, we want to have
defaultauth method across all types, for better UX.Relates to #13120