Fix documentation for meta block: string replacement in key from - to _
#15940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
jrasell
requested changes
Jan 30, 2023
There was a problem hiding this comment.
Hi @dttung2905 and thanks for raising this PR. It is looking good, however, we don't require changelog entries for documentation updates. Could you remove this, I can then get this merged. Thanks.
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
|
Thank @jrasell for the super quick review. I have removed the changelog like you suggested. You also answered what I had in mind already when I searched for past PR by |
jrasell
added
backport/website
This was referenced Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
This PR will solve the issue #15359