Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renamed "stanza" to "block" for consistency with other projects #15941

Merged
merged 1 commit into from
Jan 30, 2023
Merged

renamed "stanza" to "block" for consistency with other projects #15941

merged 1 commit into from
Jan 30, 2023

Conversation

pkazmierczak
Copy link
Contributor

resolves #15916

@pkazmierczak pkazmierczak added backport/website This will backport PR changes to `stable-website` && the latest release-branch backport/1.2.x backport to 1.1.x release line backport/1.3.x backport to 1.3.x release line backport/1.4.x backport to 1.4.x release line labels Jan 30, 2023
@pkazmierczak pkazmierczak self-assigned this Jan 30, 2023
@pkazmierczak pkazmierczak changed the title renamed stanza to block for consistency with other projects renamed "stanza" to "block" for consistency with other projects Jan 30, 2023
@pkazmierczak pkazmierczak marked this pull request as ready for review January 30, 2023 08:54
@pkazmierczak pkazmierczak requested a review from a team January 30, 2023 08:54
@pkazmierczak pkazmierczak requested review from a team as code owners January 30, 2023 08:54
tgross
tgross approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pkazmierczak pkazmierczak merged commit 949a6f6 into main Jan 30, 2023
@pkazmierczak pkazmierczak deleted the f-stanza-block-sed branch January 30, 2023 14:48
This was referenced Jan 30, 2023
Merged
Merged
Merged
Merged
pkazmierczak added a commit that referenced this pull request Jan 30, 2023
@pkazmierczak
renamed stanza to block for consistency with other projects (#15941)
287d5b1
pkazmierczak added a commit that referenced this pull request Jan 30, 2023
@pkazmierczak
renamed stanza to block for consistency with other projects (#15941)
d15c538
pkazmierczak added a commit that referenced this pull request Jan 30, 2023
@pkazmierczak
renamed stanza to block for consistency with other projects (#15941)
36a79d5
pkazmierczak added a commit that referenced this pull request Jan 30, 2023
@pkazmierczak
renamed stanza to block for consistency with other projects (#15941)
33ff2bc
pkazmierczak added a commit that referenced this pull request Jan 31, 2023
@hc-github-team-nomad-core @pkazmierczak
renamed stanza to block for consistency with other projects (#15941) (#…
104e1ce 
…15950)

Co-authored-by: Piotr Kazmierczak <470696+pkazmierczak@users.noreply.github.com>
pkazmierczak added a commit that referenced this pull request Jan 31, 2023
@hc-github-team-nomad-core @pkazmierczak
renamed stanza to block for consistency with other projects (#15941) (#…
f87136b 
…15953)

Co-authored-by: Piotr Kazmierczak <470696+pkazmierczak@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross tgross tgross approved these changes

@modrake modrake Awaiting requested review from modrake

@jeanneryan jeanneryan Awaiting requested review from jeanneryan

@schmichael schmichael Awaiting requested review from schmichael

Assignees

@pkazmierczak pkazmierczak

Labels
backport/website This will backport PR changes to `stable-website` && the latest release-branch backport/1.2.x backport to 1.1.x release line backport/1.3.x backport to 1.3.x release line backport/1.4.x backport to 1.4.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Globally replace "stanza" with "block" when referring to HCL
2 participants
@pkazmierczak @tgross