Backport of docker: set force=true on remove image to handle images referenced by multiple tags into release/1.4.x #15978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-nomad-core
force-pushed
the
backport/docker-delete-multi-tag/frankly-sacred-tapir
branch
from
0e1f046
to
09db4d5
Compare
hc-github-team-nomad-core
deleted the
backport/docker-delete-multi-tag/frankly-sacred-tapir
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #15962 to be assessed for backporting due to the inclusion of the label backport/1.4.x.
The below text is copied from the body of the original PR.
This PR changes our call of docker client
RemoveImage()toRemoveImageExtendedwiththe
Force=trueoption set. This fixes a bug where an image referenced by more thanone tag could never be garbage collected by Nomad. The Force option only applies to
stopped containers; it does not affect running workloads.
Fixes #15760