Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add upgrade notice for batch GC changes #15985

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Jan 31, 2023

Upgrade notes for #15097.

I wasn't sure how to document this change since it applies to multiple versions and the Nomad 1.5.0 already exists. I thinking duplication here is fine since we're not likely to change this and having all the major release upgrade notes under the same section makes it easier for people upgrading to 1.5.0.

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some minor points of clarity and grammar.

website/content/docs/upgrade/upgrade-specific.mdx Outdated Show resolved Hide resolved
website/content/docs/upgrade/upgrade-specific.mdx Outdated Show resolved Hide resolved
website/content/docs/upgrade/upgrade-specific.mdx Outdated Show resolved Hide resolved
website/content/docs/upgrade/upgrade-specific.mdx Outdated Show resolved Hide resolved
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with the same suggestions as @tgross.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants