Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: don't mutate global structs in core scheduler tests #16120

Merged
merged 3 commits into from
Feb 10, 2023

Commits on Feb 9, 2023

  1. tests: don't mutate global structs in core scheduler tests

    Some of the core scheduler tests need the maximum batch size for writes to be
    smaller than the usual `structs.MaxUUIDsPerWriteRequest`. But they do so by
    unsafely modifying the global struct, which creates test flakes in other
    tests.
    
    Modify the functions under test to take a batch size parameter. Production code
    will pass the global while the tests can inject smaller values.
    tgross committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    fdc9906 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    99d78e5 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. Configuration menu
    Copy the full SHA
    800241a View commit details
    Browse the repository at this point in the history