Backport of tests: don't mutate global structs in core scheduler tests into release/1.2.x #16123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Some of the core scheduler tests need the maximum batch size for writes to be smaller than the usual `structs.MaxUUIDsPerWriteRequest`. But they do so by unsafely modifying the global struct, which creates test flakes in other tests. Modify the functions under test to take a batch size parameter. Production code will pass the global while the tests can inject smaller values. Turn the `structs.MaxUUIDsPerWriteRequest` into a constant, and add a semgrep rule for avoiding this kind of thing in the future.
tgross
force-pushed
the
backport/b-flaky-core-sched-tests/miserably-guiding-stinkbug
branch
from
a0f8b18
to
1d2a243
Compare
tgross
deleted the
backport/b-flaky-core-sched-tests/miserably-guiding-stinkbug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16120 to be assessed for backporting due to the inclusion of the label backport/1.2.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Some of the core scheduler tests need the maximum batch size for writes to be smaller than the usual
structs.MaxUUIDsPerWriteRequest. But they do so by unsafely modifying the global struct, which creates test flakes in other tests.Modify the functions under test to take a batch size parameter. Production code will pass the global while the tests can inject smaller values. Turn the
structs.MaxUUIDsPerWriteRequestinto a constant, and add a semgrep rule for avoiding this kind of thing in the future.Discovered while trying to debug #16112, but this should get backported to all supported versions whereas that will be only to 1.4.x