-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
driver.rkt: support network configuration #1616
Conversation
@nak3 Thank you for taking this on! |
network += fmt.Sprintf("%s,", n) | ||
} | ||
// Trim last comma | ||
network = strings.TrimRight(network, ",") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
network := strings.Join(driverConfig.Net, ",")
would be preferred.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@schmichael Thank you. I updated it.
I rebased onto master and tried to fix your tests. If my PR #1862 looks ok we can just close this and have rkt port mappings in 0.5! |
Thank you @schmichael |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
No description provided.