driver.rkt: support network configuration #1616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nak3 Thank you for taking this on! |
| network += fmt.Sprintf("%s,", n) | ||
| } | ||
| // Trim last comma | ||
| network = strings.TrimRight(network, ",") |
There was a problem hiding this comment.
network := strings.Join(driverConfig.Net, ",") would be preferred.
There was a problem hiding this comment.
@schmichael Thank you. I updated it.
|
I rebased onto master and tried to fix your tests. If my PR #1862 looks ok we can just close this and have rkt port mappings in 0.5! |
|
Thank you @schmichael |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.