docs: remove cores/memory beta label, update driver cpu docs #16175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoenig
force-pushed
the
docs-beta-resources-label
branch
from
e151b4d
to
40ffb8c
Compare
lgfa29
approved these changes
Feb 14, 2023
| @@ -1138,6 +1138,11 @@ many CPU shares are available to your process by reading `NOMAD_CPU_LIMIT`. | |||
| Please keep the implications of CPU shares in mind when you load test workloads | |||
| on Nomad. | |||
|
|
|||
| If resources [cores][cores] is set, the task is given an isolated reserved set of | |||
There was a problem hiding this comment.
Suggested change
| If resources [cores][cores] is set, the task is given an isolated reserved set of | |
| If resources [`cores`][cores] is set, the task is given an isolated reserved set of |
| If resources [cores][cores] is set, the task is given an isolated reserved set of | ||
| CPU cores to make use of. The total set of cores the task may run on is the private | ||
| set combined with the variable set of unreserved cores. The private set of CPU cores | ||
| is available to your process by reading `NOMAD_CPU_CORES`. |
There was a problem hiding this comment.
Maybe link NOMAD_CPU_CORES to https://developer.hashicorp.com/nomad/docs/runtime/environment#job-related-variables?
| for the task. This may not be used with `cpu`. | ||
| - `cores` <code>(`int`: <optional>)</code> - Specifies the number of CPU cores | ||
| to reserve specifically for the task. This may not be used with `cpu`. The behavior | ||
| of setting `cores` is specific to each task driver (e.g. [docker][docker_cpu], [exec][exec_cpu]). |
There was a problem hiding this comment.
I wonder if it would make sense to expand task driver capabilities to include core reservation. That way we would be able to validate if the a task uses cores with a task driver that doesn't support it.
There was a problem hiding this comment.
Interesting idea - added to https://github.com/hashicorp/team-nomad/issues/373 along with thinking of PSI uses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13775