-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip tests running locally without root access #16222
Skip tests running locally without root access #16222
Conversation
258bd66
to
7a575ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @farbodahm! The CI run 7312099268 is showing a test panic in TestGenericNotifier
in helper/broker/notify_test.go
that you'll want to look into.
7a575ae
to
618b0a4
Compare
@tgross I double checked that the part which I changed didn't have any effect on the test which was failing. Also I ran the test with different parameters locally and it was fine; So I just re-run the CI (by force pushing) and everything is fine now. |
Hey @farbodahm I'm tied up in another mini-project I'm trying to ship by end of the week. I'll pick this back up next week. Just wanted to let you know that I haven't forgotten about this! 😀 |
@tgross No worries man, Please take your time and thanks for mentioning! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @farbodahm! This looks pretty good once the changes I've posted are resolved.
618b0a4
to
7321a2b
Compare
…not with root user
7321a2b
to
0b887e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'll have to wait a day to merge this -- we're in a very brief merge freeze on main
because 1.5.0 GA is coming out shortly. But once that's live I can get this in. Thanks again, @farbodahm!
@tgross No worries, Thank you so much for the review Tim. |
… not with root user (#16222)
After a short discussion with @tgross, I learned that some of the tests will fail if we run them locally and without root access.
This PR will add a functionality to skip tests if the tests:
Also it will log that the test is skipped, so if user wants to run them, she/he has to run it with root access.
In the current behavior, They are failing by saying something like:
operation not permitted
.Note: I used
make test | grep -C 5 "operation not permitted"
to find which tests require Root access, But it may not contain all of the tests which require root access.Please let me know if anything is needed; Thanks.