Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services: ensure task group is set on service hook #16240

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Commits on Feb 22, 2023

  1. services: ensure task group is set on service hook

    This PR fixes a bug where the task group information was not being set
    on the serviceHook.AllocInfo struct, which is needed later on for calculating
    the CheckID of a nomad service check. The CheckID is calculated independently
    from multiple callsites, and the information being passed in must be consistent,
    including the group name.
    
    The workload.AllocInfo.Group was not set at this callsite, due to the bug fixed in this PR.
     https://github.com/hashicorp/nomad/blob/main/client/serviceregistration/nsd/nsd.go#L114
    shoenig committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    365f26f View commit details
    Browse the repository at this point in the history