Backport of services: ensure task group is set on service hook into release/1.4.x #16241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-nomad-core
force-pushed
the
backport/b-check-not-found/neatly-content-ocelot
branch
from
401bd1a
to
e1f7e81
Compare
hc-github-team-nomad-core
force-pushed
the
backport/b-check-not-found/neatly-content-ocelot
branch
from
981a263
to
1edc4af
Compare
hc-github-team-nomad-core
deleted the
backport/b-check-not-found/neatly-content-ocelot
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16240 to be assessed for backporting due to the inclusion of the label backport/1.4.x.
The below text is copied from the body of the original PR.
This PR fixes a bug where the task group information was not being set
on the
serviceHook.AllocInfostruct, which is needed later on for calculatingthe
CheckIDof a nomad service check. TheCheckIDis calculated independentlyfrom multiple callsites, and the information being passed in must be consistent,
including the group name.
The
workload.AllocInfo.Groupwas not set at this callsite, due to the bug fixed in this PR.https://github.com/hashicorp/nomad/blob/main/client/serviceregistration/nsd/nsd.go#L114
Fixes #16238
I suspect the bug was introduced as part of #14311
Backport only to 1.4.x (when NSD checks were introduced).