Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI: fix potential state store corruptions #16256

Merged
merged 2 commits into from
Feb 27, 2023
Merged

CSI: fix potential state store corruptions #16256

merged 2 commits into from
Feb 27, 2023

Commits on Feb 24, 2023

  1. CSI: fix potential state store corruptions 

    The `CSIVolume` struct has references to allocations that are "denormalized"; we
don't store them on the `CSIVolume` struct but hydrate them on read. Tests
detecting potential state store corruptions found two locations where we're not
copying the volume before denormalizing:

* When garbage collecting CSI volume claims.
* When checking if it's safe to force-deregister the volume.

There are no known user-visible problems associated with these bugs but both
have the potential of mutating volume claims outside of a FSM transaction. This
changeset also cleans up state mutations in some CSI tests so as to avoid having
working tests cover up potential future bugs.
    @tgross
    tgross committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    a42aa15 View commit details
    Browse the repository at this point in the history

  2. changelog entry

    @tgross
    tgross committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    6aea201 View commit details
    Browse the repository at this point in the history