Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nsd: always set deregister flag after deregistration of group #16289

Merged
merged 2 commits into from
Mar 17, 2023
Merged

nsd: always set deregister flag after deregistration of group #16289

merged 2 commits into from
Mar 17, 2023

Commits on Mar 17, 2023

  1. services: always set deregister flag after deregistration of group 

    This PR fixes a bug where the group service hook's deregister flag was
not set in some cases, causing the hook to attempt deregistrations twice
during job updates (alloc replacement).

In the tests ... we used to assert on the wrong behvior (remove twice) which
has now been corrected to assert we remove only once.

This bug was "silent" in the Consul provider world because the error logs for
double deregistration only show up in Consul logs; with the Nomad provider the
error logs are in the Nomad agent logs.
    @shoenig
    shoenig committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    8205b89 View commit details
    Browse the repository at this point in the history

  2. services: cleanup group service hook tests

    @shoenig
    shoenig committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    26d7e41 View commit details
    Browse the repository at this point in the history