Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: refactor service interpolation #16413

Closed
wants to merge 1 commit into from
Closed

client: refactor service interpolation #16413

wants to merge 1 commit into from

Commits on Mar 9, 2023

  1. client: refactor service interpolation 

    Services may reference runtime variables that must be interpolated in
the client when reading them, otherwise any equality check fails because
something like `${NOMAD_NAMESPACE}` is compared with its rendered value
stored in the service catalog.

This change attempts to make this requirement easier to discover by
providing methods in the `TaskGroup` and `Task` structs that return the
interpolated services.

These methods take a `ServiceInterpolator` interface to avoid a circular
dependency between the `structs` and `taskenv` packages.
    @lgfa29
    lgfa29 committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    53dd4fb View commit details
    Browse the repository at this point in the history