Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cgv1: do not disable cpuset manager if reserved interface already exists #16467

Merged
merged 2 commits into from
Mar 13, 2023
Merged

cgv1: do not disable cpuset manager if reserved interface already exists #16467

merged 2 commits into from
Mar 13, 2023

Commits on Mar 13, 2023

  1. cgv1: do not disable cpuset manager if reserved interface already exists 

    This PR fixes a bug where restarting a Nomad Client on a machine using cgroups
v1 (e.g. Ubuntu 20.04) would cause the cpuset cgroups manager to disable itself.

This is being caused by incorrectly interpreting a "file exists" error as
problematic when ensuring the reserved cpuset exists. If we get a "file exists"
error, that just means the Client was likely restarted.

Note that a machine reboot would fix the issue - the groups interfaces are
ephemoral.
    @shoenig
    shoenig committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    7d77901 View commit details
    Browse the repository at this point in the history

  2. cl: add cl

    @shoenig
    shoenig committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    cdf483a View commit details
    Browse the repository at this point in the history