Backport of nsd: always set deregister flag after deregistration of group into release/1.5.x #16538
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16289 to be assessed for backporting due to the inclusion of the label backport/1.5.x.
The below text is copied from the body of the original PR.
This PR fixes a bug where the group service hook's deregister flag was not set in
Postrun()
, causing the hook to attempt deregistrations twice during job updates (alloc replacement), wherePreKill()
would also do a deregistration. With the Nomad service provider, this shows up as Error logs on every job update.First commit is the bug fix, second is drive by test cleanup.