Nomad service name validation stricter than Consul validation #16691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juanadelacuesta
changed the title
tgross
reviewed
Mar 28, 2023
There was a problem hiding this comment.
The code LGTM but I have two comments in terms of our intent:
- The wording of the warning suggests that it's an error.
- Do we really want to make this change? I realize that having consistency with the Consul services would be nice, but having a stricter validation for our own services means we could more easily add DNS support for Nomad SD without worrying about backwards compatibility later on.
Co-authored-by: Tim Gross <tgross@hashicorp.com>
Co-authored-by: Tim Gross <tgross@hashicorp.com>
Juanadelacuesta
force-pushed
the
b-gh-11097
branch
from
fc6f7bf
to
ee286e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the bug reported on #11097
When a new service is created, the name should comply with RFC-1123, this validation is enforced on Nomad, but not on consul. This PR relaxes the Nomad validation and instead of an error, it shows a warning for the non compliant service name.