Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: move pause container recovery to after SetConfig #16713

Merged
merged 1 commit into from
Mar 29, 2023

Commits on Mar 29, 2023

  1. docker: move pause container recovery to after SetConfig

    When we added recovery of pause containers in #16352 we called the recovery
    function from the plugin factory function. But in our plugin setup protocol, a
    plugin isn't ready for use until we call `SetConfig`. This meant that
    recovering pause containers was always done with the default
    config. Setting up the Docker client only happens once, so setting the wrong
    config in the recovery function also means that all other Docker API calls will
    use the default config.
    
    Move the `recoveryPauseContainers` call into the `SetConfig`. Fix the error
    handling so that we return any error but also don't log when the context is
    canceled, which happens twice during normal startup as we fingerprint the
    driver.
    tgross committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    fef719c View commit details
    Browse the repository at this point in the history